search

OpenCraft-Studios / OpenCraft

A roughly calculated clone of Minecraft
BSD 3-Clause "New" or "Revised" License
5 stars 2 forks source link

Automatically create a opencraft.bat at opencraft compiling #45

Closed quentin452 closed 5 hours ago

cliserkad commented 19 hours ago

The installer .bat that I wrote for this project is intended for end users who aren't downloading the sources or building the project at all. The readme doesn't have a link to download that installer because @CiroZDP and I disagreed on whether a PowerShell or .bat script is better. If you'd like to write an improved installer that would be nice, but I suspect it will either be basic and limited or complex and hard to work with. Installing java automatically would be great, but I think it's a little complicated on windows.

I think we'll just link to the existing .bat script that is uploaded to the auto-release. Generating an installer for people who build from source doesn't seem like it adds much convenience. You can set the default program for .jar files to java.exe so it runs with a double click.

Also, we are requiring signed commits on the main branch. GitHub Docs on commit signatures

cliserkad commented 19 hours ago

See #46 for my install script proposal.

CiroZDP commented 5 hours ago

I don't really care about signed commits.

By the way, if you want to create a script for OpenCraft installing you must go to the https://opencraft-studios.github.io/install.ps1 script and modify it. It must be coded in PowerShell because you can execute and download code more easily. Copy and pasting one line in the terminal is more easy to do than download a file and double click it (IMHO).