search

OpenCraft-Studios / opencraft

A roughly calculated clone of Minecraft
BSD 3-Clause "New" or "Revised" License
7 stars 1 forks source link

➖ Remove installer #59

Closed CiroZDP closed 2 weeks ago

cliserkad commented 2 weeks ago

This literally just breaks the current builds without replacing them

CiroZDP commented 2 weeks ago

This literally just breaks the current builds without replacing them

How?

cliserkad commented 2 weeks ago

You deleted it all. But there's not a new build system yet

CiroZDP commented 2 weeks ago

Why a new build system?

CiroZDP commented 2 weeks ago

This is remove installer branch. We could do a create artifacts for launcher branch.

cliserkad commented 2 weeks ago

ok, just create a new branch called "launcher" from this branch. Then when the launcher is complete it will replace the current system

CiroZDP commented 2 weeks ago

Ok, accept this pr first. Please

cliserkad commented 2 weeks ago

This PR breaks the current system! We won't have any working builds

CiroZDP commented 2 weeks ago

It doesn't breaks it. It deletes it.

CiroZDP commented 2 weeks ago

we could do another branch launcher to create another build system

CiroZDP commented 2 weeks ago

but first you'll need to accept

cliserkad commented 2 weeks ago

You can have many commits in your branch while you work on it. There's no reason to break the main branch's builds.

CiroZDP commented 2 weeks ago

But this branch is remove installer

CiroZDP commented 2 weeks ago

Should i rename it to launcher?