search

OpenCubicChunks / CubicChunks2

Infinite* height mod for Minecraft - rewrite for versions above 1.12
MIT License
77 stars 18 forks source link

Rewrite block lighting to work properly at high distances #15

Open muzikbike opened 4 years ago

muzikbike commented 4 years ago

1.14 rewrote lighting to allow for directional opacity of blocks. While this is completely fine within reasonable distances, it completely breaks beyond 33554432 blocks on the X and Z axes: 2020-07-11_15 30 01

For the Y axis, it breaks beyond 2048: 2020-07-11_09 08 13 2020-07-11_09 08 15 2020-07-11_10 01 46 2020-07-11_10 01 48

And with cubic chunks, this still holds true, if a bit differently: 2020-07-11_15 14 22

So in order for lighting to work correctly at any depth/height (or outwards distance for OpenCubicChunks/CubicChunks#535) block lighting might need some serious rewriting. (An absurd ask: maybe this rewrite could also implement coloured lighting on the side? After all, the 1.7.10 coloured light mod (https://github.com/CptSpaceToaster/CptsModdingLight/issues/58) is in need of someone to maintain it, so it being merged into CC and continued with it with the necessary lighting fixes for CC would be fantastic.)

NotStirred commented 4 years ago

This will come with the lighting fix https://github.com/OpenCubicChunks/CubicChunks/issues/529 coloured lighting is far beyond the scope of CC, but I might look at doing it in a separate mod some time in the future

muzikbike commented 4 years ago

Relevant bug tracker ticket: https://bugs.mojang.com/browse/MC-194878