search

OpenCubicChunks / CubicChunks2

Infinite* height mod for Minecraft - rewrite for versions above 1.12
MIT License
77 stars 18 forks source link

Rewrite vanilla lighting #18

Open NotStirred opened 4 years ago

NotStirred commented 4 years ago

Currently lighting information is being sent from the server to the client correctly, but the information itself is completely wrong.

Vanilla lighting assumes that an entire column is loaded before lighting is done, which is of course flawed for CC.

Will most likely require an entire rewrite of the skylight system (both SkyLightStorage and SkyLightEngine)

NotStirred commented 4 years ago

Also: Investigate why spawn chunks seem to be lit correctly, while everything else is broken. Does spawn fully generate columns before doing any lighting? It shouldn't be doing anything different but it has to be as it's working

CursedFlames commented 3 years ago

Current status: server-side lighting seems to work correctly, both during worldgen and when there are block updates. Obviously no handling of unloading/loading yet, since we've yet to do save file stuff. Client-side lighting is still broken.

CursedFlames commented 3 years ago

Current status: lighting is mostly correct, except for non-deterministic light leaking in caves sometimes, which may be due to a race condition.