OpenCubicChunks / CubicChunks2

Infinite* height mod for Minecraft - rewrite for versions above 1.12
MIT License
77 stars 18 forks source link

Track unmodified methods and warn on unexpected/missing methods for important classes #75

Open CursedFlames opened 2 years ago

CursedFlames commented 2 years ago

In order to mitigate possible issues with us missing changes in future minecraft updates, in our ASM transformations we may want to track unmodified methods as well as transformed ones. We could then detect when there are missing methods, or untransformed methods that aren't in this list, indicating new methods.

Doing this for every class would be excessive, but doing it for some of the important classes (Level, ClientLevel, ServerLevel, LevelChunk etc.) could help us catch bugs while updating to new minecraft versions.

Once our ASM transformations are data-driven, this could, for example, take the form of an extra array of untransformed method names for each important class.