Light and non-light heightmaps can be wildly different due to early loading of light into global heightmaps

OpenCubicChunks / CubicChunks2

Infinite* height mod for Minecraft - rewrite for versions above 1.12

MIT License

77 stars 18 forks source link

Light and non-light heightmaps can be wildly different due to early loading of light into global heightmaps #76

Open NotStirred opened 2 years ago

NotStirred commented 2 years ago

Whereas light heightmaps are loaded into the global heightmaps at FEATURES status, non-light heightmaps are loaded into global at promotion to LevelCube. If some terrain is on the edge of your render distance (such as an island in a sky islands world) this would mean that the heightmaps could be very different.

Is this an issue? I'm not sure we should even do anything about this, thoughts?

CursedFlames commented 2 years ago

This could cause behavior such as getting rainfall in areas that don't have skylight, but I agree that it doesn't seem particularly problematic. Probably leave it as-is for now but keep this issue open until we get closer to release and see if any problems arise.