search

OpenCubicChunks / CubicChunks2

Infinite* height mod for Minecraft - rewrite for versions above 1.12
MIT License
72 stars 21 forks source link

Remove Cube-specific DistanceManager#addPlayer and removePlayer. Closes #51 #85

Closed pufmat closed 2 years ago

NotStirred commented 2 years ago

This PR actually brings up something interesting. We shouldn't need chunk player tickets at all, they should be handled fully by COLUMN tickets.

I'm not sure if any mods depend on ticket type - though it would be weird if they did

NotStirred commented 2 years ago

Discussion on discord here. We should replace the vanilla implementation instead of keeping both. Perhaps a cancellable Inject at HEAD?

NotStirred commented 2 years ago

After looking into it a bit more, it's probably best to not do this, it's a bit of a rabbit hole sadly