search

OpenCubicChunks / CubicWorldGen

Customizable CubicChunks world generation
MIT License
55 stars 23 forks source link

Cubic Flat layer fixer #18

Closed Foghrye4 closed 5 years ago

Foghrye4 commented 5 years ago

Screenshot from 2019-03-16 20-34-13 screen1 MalisisCore UISelect sux.

Barteks2x commented 5 years ago

How does that handle 2 layers with different biome in the same cube?

The multilayer superflat GUI is hard to use as it is. Manually typing height ranges into text fields where it doesn't fit. Lack of "-infinity" option. The blockstate selection GUI being nearly impossible to understand system, mixed together with layers (somehow?).

If you are going to improve it, re-do it in a better way. This time I'm not going to accept something like the current code that it is. I keep seeing a pattern where your code mostly works, but is nearly impossible to understand, modify and fix by anyone else. Things that shouldn't be linked together, are linked in a way that is almost impossible to separate without rewriting it. Or maybe I just can't understand other people's code. I have no way to know, because there is noone else to review it.

Foghrye4 commented 5 years ago

Redone. Now contain only Json settings fixer. Other things - later.

Barteks2x commented 5 years ago

Later being "in a different PR" or "later in this PR"?

Foghrye4 commented 5 years ago

Later in different PR.