search

OpenCyphal-Garage / gui_tool

Legacy cross-platform GUI application for UAVCAN/CAN v0 bus management and diagnostics. Does not support UAVCAN v1; for that, see Yukon.
http://legacy.uavcan.org
MIT License
85 stars 53 forks source link

Add motor efficient analysis module #20

Closed hehongyu1995 closed 7 years ago

hehongyu1995 commented 7 years ago

I just add a motor efficient analysis module to this project ,which is not finish yet, but enough to use some of the ways. This module provides manual control and automatic control , samples can save to .CSV file for further analysis. A HX711 load cell sensor which connect to a Arduino has been used to collect thrust data.

pavel-kirienko commented 7 years ago

Thank you for this contribution! This might really be a useful tool for bench testing.

However, while the code is undoubtedly useful, it does not seem to match the standards adopted in this project. If you looked at the diff you would see a lot of meaningless changes, such as added and removed empty lines, changed formatting, misleading copyright statements, and entities named in a way that does not adhere to PIP8.

It is questionable whether this feature would be at home within the UAVCAN GUI Tool since its specifics seem rather detached from UAVCAN. I suggest you extract your code into a separate application, which can be based on the UAVCAN GUI Tool, and host it in a dedicated repository. If you choose to do so, I urge you to avoid using my name in copyright statements provided with code I didn't write.

Thank you!