search

OpenCyphal-Garage / libcyphal

Portable reference implementation of the Cyphal protocol stack in C++ for embedded systems and Linux.
http://opencyphal.org
MIT License
292 stars 502 forks source link

Refactor Linux Driver #305

Closed thirtytwobits closed 4 years ago

thirtytwobits commented 4 years ago

I did a similar refactor downstream to support a posix-like RTOS internally. I'm submitting this but with our RTOS-specific driver removed to allow Peter to refactor his nuttx driver to share most of its implementation with linux.

sonarcloud[bot] commented 4 years ago

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

pavel-kirienko commented 4 years ago

Why did you remove the LPC11C24 driver?

pavel-kirienko commented 4 years ago

Actually, none of the platform drivers should be here anyway. I suggest moving this changeset over to https://github.com/UAVCAN/platform_specific_components/tree/legacy-v0/linux/libuavcan.

thirtytwobits commented 4 years ago

Why did you remove the LPC11C24 driver?

It seemed incredibly out of date. When's the last time anyone actually verified this worked? I can add it back but is it at all relevant at this point?

pavel-kirienko commented 4 years ago

It is certainly not out of date and it is actually used in OpenGrab EPM v3, for example. If it's not being updated it doesn't mean that it's dead, it's just finished and there's nothing else to change.

pavel-kirienko commented 4 years ago

Closing due to #307.