Closed serges147 closed 6 months ago
ContiguousPayload
can::TransportImpl::run
runMediaTransmit
ITransport
setLocalNodeId
memcpy
memmove
inline
std::
Also:
noexcept
override
final
Coverage:
@lydia-at-amazon Lidia, please see my answers. Thnx!
Thanks for responding to all the comments, Sergei! Looks good, will go through and resolve them.
ContiguousPayload
)can::TransportImpl::run
now peeks, pushes to media, and finally pops TX queue items (seerunMediaTransmit
)ITransport
with newsetLocalNodeId
methodmemcpy
→memmove
inline
-sstd::
prefixes before std integralsAlso:
noexcept
were lostoverride
→final
where applicable (for Scott ;) )Coverage: