OpenCyphal-Garage / libcyphal

Portable reference implementation of the Cyphal protocol stack in C++ for embedded systems and Linux.
http://opencyphal.org
MIT License
300 stars 501 forks source link

No CETL_NODISCARD for most of the public api #359

Closed serges147 closed 6 months ago

serges147 commented 6 months ago

No CETL_NODISCARD for the most of public api (issue #350), but private (aka detail) stuff stays under strict [[nodiscard]] policy for all non-void returning functions.

Also:

sonarcloud[bot] commented 6 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
1 Accepted issue

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

lydia-at-amazon commented 6 months ago

nit: Title of PR: No CETL_NODISCARD for the most of public api --> No CETL_NODISCARD for most of the public api

sonarcloud[bot] commented 6 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
1 Accepted issue

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud