OpenCyphal-Garage / libcyphal

Portable reference implementation of the Cyphal protocol stack in C++ for embedded systems and Linux.
http://opencyphal.org
MIT License
300 stars 501 forks source link

Remove `None` as a scheduling option #372

Closed pavel-kirienko closed 3 months ago

pavel-kirienko commented 3 months ago

This special case doesn't look convincing. I understand that there is some value in being able to unschedule a callback but as far as I understand by now we haven't identified an explicit need for that, and it would be easy to retrofit -- if needed -- later. The troubling thing here is that an extension of any well-structured set of entities with a special case often tends to break the design in unexpected ways at some point.

But I couldn’t resist the temptation to put in a null reference, simply because it was so easy to implement.

_Originally posted by @pavel-kirienko in https://github.com/OpenCyphal-Garage/libcyphal/pull/371#discussion_r1704753104_

serges147 commented 3 months ago

Notes:

serges147 commented 3 months ago

Closing as fixed by PR #376