[UAVCAN/CAN] SocketCAN/libcanard: update socketcan.h

OpenCyphal-Garage / platform_specific_components

Low-level components and hardware drivers for various Cyphal-related projects

https://opencyphal.org

MIT License

72 stars 40 forks source link

[UAVCAN/CAN] SocketCAN/libcanard: update socketcan.h #20

Closed pavel-kirienko closed 3 years ago

pavel-kirienko commented 3 years ago

Fix https://github.com/UAVCAN/platform_specific_components/issues/19

@TomDeRybel does it answer your question?

pavel-kirienko commented 3 years ago

@TomDeRybel irrespective of this PR, we would welcome a patch extending the SocketCAN wrapper API with loopback flags. I imagine it would be an extra boolean output parameter to socketcanPop(..., &loopback). If the flag pointer is NULL, loopback frames are to be silently dropped; if not NULL, they are to be accepted and indicated using this flag. The initialization function would then always set the RECV_OWN_MSGS option.

TomDeRybel commented 3 years ago

Wow, that was fast!

Your proposal sounds good. I will start the required work on Monday.

Have a nice weekend, Tom