`pf17::overloaded` & `pf17::make_overloaded` have to be out of PF17 namespace - Githubissues

OpenCyphal / CETL

Cyphal Embedded Template Library

MIT License

12 stars 3 forks source link

`pf17::overloaded` & `pf17::make_overloaded` have to be out of PF17 namespace #130

Closed serges147 closed 4 months ago

serges147 commented 4 months ago

Currently, b/c of the polyfill thing, make_overloaded can't be used on c++ >= 17 - stuff from cetl::pf17:: ... namespace is not exposed when user includes cetl/pf17/cetlph.hpp. So, such non-std utility type and function should be moved to some place else.

Proposal for the move:

cetl::pf17::overloaded → cetl::overloaded
cetl::pf17::make_overloaded → cetl::make_overloaded
move these two above entities out of cetl/pf17/utility.hpp file to a new cetl/visit_helpers.hpp header.

@pavel-kirienko @thirtytwobits What do you think?

serges147 commented 4 months ago

Fixed by https://github.com/OpenCyphal/CETL/pull/131