search

OpenCyphal / libcanard

A compact implementation of the Cyphal/CAN protocol in C for high-integrity real-time embedded systems
http://opencyphal.org
MIT License
332 stars 192 forks source link

relaxing the language support to C99 #151

Closed nacansino closed 4 years ago

nacansino commented 4 years ago

Description of PR

This pull request relaxes the requirement of C-compiler to C99.

Changes

There are no changes to the logical portion of the code. All changes are either related to suppressing the compile-time compiler verification or to the documentation. However, some notable changes in this PR are:

Caveats

I was not able to test the library using the tests/ directory due to my failure to replicate the build system (my attempt was rife with clang-tidy errors - of which fixing may take an amount of time exceeding the total time needed for the PR itself). I am hoping for the CI to test this PR for me.

pavel-kirienko commented 4 years ago

If you want to rely on our CI to validate your code, you can switch this PR into the draft mode, push your changes as many times as necessary, then squash your commits and let us know when it's ready for another look. Thanks!

nacansino commented 4 years ago

@pavel-kirienko Sorry there has not been any progress here lately. Anyway, should I pull here the changes on https://github.com/UAVCAN/libcanard/pull/152?