search

OpenCyphal / libcanard

A compact implementation of the Cyphal/CAN protocol in C for high-integrity real-time embedded systems
http://opencyphal.org
MIT License
332 stars 192 forks source link

Create Android.bp #156

Closed manmountain closed 3 years ago

manmountain commented 3 years ago

Build libcanard for Android Open Source Project

pavel-kirienko commented 3 years ago

Thanks! I have two questions:

  1. Can you please describe in a few sentences the intended use case for this, perhaps in the header comment of the file you just added? Otherwise, somebody not familiar with Android native (like myself) might get lost.

  2. Can you set up a basic CI pipeline for this in .travis.yml?

pavel-kirienko commented 3 years ago

Or maybe it's better to extract this build recipe into a separate platform-specific component?

pavel-kirienko commented 3 years ago

Or maybe it's better to extract this build recipe into a separate platform-specific component?

To be more specific, I suggest we create /android/libcanard and put all Android-specific items in there.

manmountain commented 3 years ago

Do you mean to create /android/libcanard in platform_specific_components? And put libcanard's Android.bp file in that repo also?

pavel-kirienko commented 3 years ago

Do you mean to create /android/libcanard in platform_specific_components? And put libcanard's Android.bp file in that repo also?

Yes to both.

manmountain commented 3 years ago

The best thing for now is maybe just to merge the Android.bp make files to a 'android' branch in both libcanard and platform_specific_components repos. Im working on adding a /android/libcanard that using the hardware abstraction layer for the can bus on Android platforms to platform_specific_components.

pavel-kirienko commented 3 years ago

The best thing for now is maybe just to merge the Android.bp make files to a 'android' branch in both libcanard and platform_specific_components repos.

Why is that better though? Does your workflow depend on that branch being available? I'm not sure I understand the motivation here.

I can help you set up the platform-specific repo for Android if you want, although I can't think of anything requiring setting up beyond creating the directory and adding a new build pipeline to travis.yml.

pavel-kirienko commented 3 years ago

@manmountain are you planning to update this PR?

pavel-kirienko commented 3 years ago

Closing as stale. Feel free to re-open if you get back to this later.