Closed jvishnefske closed 1 year ago
Thanks! The first one is legit -- although it has no practical significance, it is technically a UB, so I opened #204 to fix it. The other two are unhelpful.
Could you please help us set up the sanitizer in the CI?
Started #205 in attempt to add sanitizer to cmake build. It may take some experimenting to get right on CI.
I compiled canard.c from release tarball 3.0.0, and the public catch2 tests with my meson file. -fsanitize=undefined seems to be triggering while running unit tests.
../subprojects/libcanard-3.0.0/tests/test_public_tx.cpp:101: PASSED: REQUIRE( 3 == alloc.getNumAllocatedFragments() ) with expansion: 3 == 3![Screenshot](https://user-images.githubusercontent.com/8574077/198737301-d49f3a4a-2dfe-42f2-a1fa-91de94a36d5f.png)
../subprojects/libcanard-3.0.0/libcanard/canard.c:413:47: runtime error: member access within null pointer of type 'struct TxItem' ../subprojects/libcanard-3.0.0/tests/test_public_tx.cpp:107: PASSED: REQUIRE( -3 == que.push(&ins.getInstance(), 1'000'000'000'300ULL, meta, 100, payload.data()) ) with expansion: -3 == -3