search

OpenCyphal / libudpard

A compact implementation of the Cyphal/UDP protocol in C for high-integrity real-time embedded systems
MIT License
10 stars 8 forks source link

Remove macro defined versions from catch.hpp #12

Closed SchoberMJ closed 1 year ago

SchoberMJ commented 1 year ago

Macro defined constants result in errors when running make VERBOSE=1 as it is against cpp core guidelines macros usage.

pavel-kirienko commented 1 year ago

I would rather say that the build recipe is misconfigured because catch.hpp is a third-party dependency so it should be compiled with only minimal warnings enabled. See the related recent discussion here: https://github.com/OpenCyphal/nunavut/issues/271#issuecomment-1401659301

SchoberMJ commented 1 year ago

Looks like there are some format errors as well, from the style check. And another issue where -Werror is turned off in the cmake flags.