search

OpenCyphal / libudpard

A compact implementation of the Cyphal/UDP protocol in C for high-integrity real-time embedded systems
MIT License
10 stars 8 forks source link

txGenerateMultiFrameChain computes incorrect frame index on subsequent frames #25

Closed emrainey closed 1 year ago

emrainey commented 1 year ago

After udpardTxPush was called with a message of 2112 bytes (serialized uavcan.node.port.List), the code broke the payload into 2 parts which seems correct. The first part got assigned a frame_index of 0, but the second was assigned a frame_index of 2 (w/ EOT too). The specification indicates that the index should be sequential.

lydia-at-amazon commented 1 year ago

This was related to https://github.com/OpenCyphal-Garage/libudpard/issues/19. The fix was provided in https://github.com/OpenCyphal-Garage/libudpard/pull/27