Closed pavel-kirienko closed 11 months ago
👀
Kudos, SonarCloud Quality Gate passed!
0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell
92.2% Coverage
0.0% Duplication
The version of Java (11.0.17) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here
Implement the common parts of the RX pipeline. At this point, about 90% of the work is done. All that is left is to add the basic public API wrappers for subscriptions and RPC-services. For details about the implementation of the RX pipeline refer to the line that says "Internally, the RX pipeline is arranged as follows".
Slightly refactor the code added earlier to uphold orthogonality and avoid unnecessary duplication.
Trivial renamings to keep names shorter, e.g.:
UdpardConstPayload
->UdpardPayload
(const implied by default; there's alsoUdpardMutablePayload
)UdpardPayloadFragmentHandle
->UdpardFragment
Establish an internal convention that functions named "Destroy" deallocate the passed memory while "Free" only deallocate the memory of the associated resources. This is not API-visible.
Remove the
port_id
field fromUdpardRxPort
because it is not needed.After this is merged, the remaining task is to simply implement the public RX pipeline functions on top of:
rxPortInit
rxPortAcceptFrame
rxPortFree
The test coverage is supposed to be full but llvm-cov slightly misreports it.