search

OpenCyphal / nunavut

Generate code from DSDL using PyDSDL and Jinja2
https://nunavut.readthedocs.io/
Other
39 stars 24 forks source link

migrate pyuavcan.dsdl generation core to lang/py #234

Closed coderkalyan closed 2 years ago

coderkalyan commented 2 years ago

I patched the nunavut core to support (recursive) directories in the support directory, but then ended up consolidating all the python support code into a single file nunavut_support.py. Leaving this here in case it comes in handy in the future, it doesn't add any notable complexity. LMK if it should be removed.

Pyuavcan PR coming up in a minute.

coderkalyan commented 2 years ago

Actually, I need to check a couple things. Feel free to review though.

thirtytwobits commented 2 years ago

This is great. I'll review this tomorrow

thirtytwobits commented 2 years ago

Please run tox -e lint locally and correct all formatting and mypy errors.

thirtytwobits commented 2 years ago

You need to add numpy to setup.cfg as an install_requires

coderkalyan commented 2 years ago

Please run tox -e lint locally and correct all formatting and mypy errors.

Already done, will push after fixing a couple mypy issues.

thirtytwobits commented 2 years ago

This PR is stale. Resubmit to continue with the review. Thanks.