OpenCyphal / nunavut

Generate code from DSDL using PyDSDL and Jinja2
https://nunavut.readthedocs.io/
Other
39 stars 24 forks source link

Address regression introduced with PyDSDL v1.14 #248

Closed pavel-kirienko closed 2 years ago

pavel-kirienko commented 2 years ago

This was reported this morning by @PonomarevDA

The PyDSDL v1.14 changeset is here: https://github.com/UAVCAN/pydsdl/pull/77

The PyDSDL v1.15 changeset is here: https://github.com/UAVCAN/pydsdl/pull/80

I also removed Python 3.6 from the classifiers but this does not address the root of the problem, which is that we have the same information listed in several places, and it is certain that inconsistencies will occasionally emerge. I suggest removing the list of Python versions from the classifiers.

pavel-kirienko commented 2 years ago

@thirtytwobits

download

thirtytwobits commented 2 years ago

I'm not okay with removing Python 3.6 support. Is that a requirement for this change?

pavel-kirienko commented 2 years ago

I can go back and restore Python 3.6 support in PyDSDL but what do we need that for?

thirtytwobits commented 2 years ago

I can go back and restore Python 3.6 support in PyDSDL but what do we need that for?

An ability to retrofit existing systems.

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

pavel-kirienko commented 2 years ago

@thirtytwobits support for Python 3.6 is back