Reverted usage of select_on_container_copy_construction()

OpenCyphal / nunavut

Generate code from DSDL using PyDSDL and Jinja2

https://nunavut.readthedocs.io/

Other

39 stars 24 forks source link

Reverted usage of select_on_container_copy_construction() #350

Closed serges147 closed 3 weeks ago

serges147 commented 1 month ago

Reverted usage of select_on_container_copy_construction() - it broke libcyphal unit tests where there are unit tests which verify that there is no usage of the default PMR.

select_on_container_copy_construction() does exactly this - it create a completely new instance of allocator:

without transferring underlining memory resource
but instead getting the default pmr::memory_resource()

sonarcloud[bot] commented 1 month ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

serges147 commented 3 weeks ago

Closing this PR b/c with https://github.com/OpenCyphal-Garage/libcyphal/pull/394 it is not needed anymore.