OpenCyphal / pycyphal

Python implementation of the Cyphal protocol stack.
https://pycyphal.readthedocs.io/
MIT License
119 stars 106 forks source link

v0: rename package to pyuavcan_v0 #170

Closed coderkalyan closed 3 years ago

coderkalyan commented 3 years ago

Do not merge until tested.

Fixes #166

coderkalyan commented 3 years ago

@pavel-kirienko Not sure what's wrong here, the twine upload is giving a 403 forbidden - is there a separate token/password for each pypi package that you need to update?

pavel-kirienko commented 3 years ago

is there a separate token/password for each pypi package that you need to update?

Yes, that's the preferred way because it securer. However, your new configuration will create a new package becase currently there is no package named pyuavcan_v0, so I guess we need an unscoped token for that.

Please tell me your PyPI username so that I could add you as a co-maintainer there. After the first version is published we should replace that unsafe token with a constrained one.

pavel-kirienko commented 3 years ago

AppVeyor looks sad. I think it needs an .appveyor.yaml with build: off in it.

coderkalyan commented 3 years ago

Ok then. I added back the original appveyor (which is already disabled).

pavel-kirienko commented 3 years ago

Nice. Let's wait for the GUI tool test and then it should be good to merge.

coderkalyan commented 3 years ago

It seems that the dsdl_files directory isn't being installed with the package.

pavel-kirienko commented 3 years ago

Maybe the repository is not cloned recursively?

coderkalyan commented 3 years ago

You're right. I cloned recursively for the tests but not for the publishing job!

coderkalyan commented 3 years ago

Alright. @pavel-kirienko The gui tool boots up now: https://github.com/UAVCAN/gui_tool/pull/51

(I published a new version, 1.0.0.dev34)