OpenCyphal / pycyphal

Python implementation of the Cyphal protocol stack.
https://pycyphal.readthedocs.io/
MIT License
119 stars 106 forks source link

Seeedstudio support #175

Closed dmitriyyushmanov closed 2 years ago

dmitriyyushmanov commented 3 years ago

Please be aware, python-can 4.0 (which contains seeedstudio) is not released yet. That's why I did not touch version in setup.cfg

coveralls commented 3 years ago

Pull Request Test Coverage Report for Build 40530441


Files with Coverage Reduction New Missed Lines %
/home/appveyor/projects/pyuavcan/pyuavcan/application/plug_and_play.py 1 92.24%
/home/appveyor/projects/pyuavcan/pyuavcan/presentation/_presentation.py 1 94.55%
/home/appveyor/projects/pyuavcan/pyuavcan/application/node_tracker.py 3 87.37%
/home/appveyor/projects/pyuavcan/pyuavcan/transport/can/media/pythoncan/_pythoncan.py 40 68.95%
<!-- Total: 45 -->
Totals Coverage Status
Change from base Build 40116599: -0.09%
Covered Lines: 13411
Relevant Lines: 13860

💛 - Coveralls
dmitriyyushmanov commented 3 years ago

I don't think it is wise to merge it until this feature is actually supported in a stable release of PythonCAN. Do you know if there is any ETA?

I suggest we let this pull request sit until v4 is available and PyUAVCAN is shown to be compatible with PythonCAN v4 (will need your help there).

Sure, no problem

pavel-kirienko commented 2 years ago

@dmitriyyushmanov PythonCAN 4.0 seems to be out now! Can we please have your changeset rebased to the latest master and the minor version be incremented? Thanks!

dmitriyyushmanov commented 2 years ago

@pavel-kirienko I hope I can do it in a couple of days.

pavel-kirienko commented 2 years ago

Superseded by https://github.com/OpenCyphal/pycyphal/pull/216