search

OpenCyphal / pycyphal

Python implementation of the Cyphal protocol stack.
https://pycyphal.readthedocs.io/
MIT License
119 stars 106 forks source link

Update classic CAN vs CAN-FD auto detection heuristic #187

Closed coderkalyan closed 2 years ago

coderkalyan commented 2 years ago

Closes #184

pavel-kirienko commented 2 years ago

I recommend configuring a File Watcher to automatically run Black on save -- it helps avoid broken builds like you have here caused by misformatted sources.

coderkalyan commented 2 years ago

Yes, you're right, I should. I should also be more careful and review diffs before pushing. Apologies.

pavel-kirienko commented 2 years ago

PSA: I see that you use force-pushing, presumably to maintain clean history. This is admirable but not really necessary in our repositories because we use squash merging -- all your commits will be squashed into one when merging anyway. This is just FYI.

coderkalyan commented 2 years ago

PSA: I see that you use force-pushing, presumably to maintain clean history. This is admirable but not really necessary in our repositories because we use squash merging -- all your commits will be squashed into one when merging anyway. This is just FYI.

Thanks for the heads up. Yes, this is a habit I've grown from other repositories that use rebase merging rather than squash. I'll keep it in mind.