search

OpenCyphal / pycyphal

Python implementation of the Cyphal protocol stack.
https://pycyphal.readthedocs.io/
MIT License
117 stars 105 forks source link

Support more python-can configuration options #264

Closed chemicstry closed 1 year ago

chemicstry commented 1 year ago

Current implementation splits environment variable by colon and checks if there are excatctly 2 parts. This does not work with some of the python-can configuration options, like SLCAN over TCP where channel name is socket://192.168.254.254:5000 instead of just COM1.

Would it make sense to split just the first colon and ignore the rest? Or would it be better to use some other format than colon?

pavel-kirienko commented 1 year ago

Would it make sense to split just the first colon and ignore the rest?

Yes, a change request would be accepted.