Closed Willmac16 closed 10 months ago
It looks like Yakut needs the pycyphal.dsdl.([a-z_]+)
-> nunavut_support.$1
treatment.
Unrelated, should the package be marked as zip_safe
in setup.cfg at this point?
Unrelated, should the package be marked as
zip_safe
in setup.cfg at this point?
Maybe, but it would probably be a micro-optimization and this flag is obsolete either way, so I prefer not to touch it. See https://setuptools.pypa.io/en/latest/deprecated/zip_safe.html
It looks like Yakut needs the pycyphal.dsdl.([a-z_]+) -> nunavut_support.$1 treatment.
I have opened a ticket about this in the Yakut repo. Would you be available to submit the required changes there? For testing, you can replace the PyCyphal dependency specification as follows:
install_requires =
- pycyphal[transport-udp,transport-serial,transport-can-pythoncan] ~= 1.8
+ pycyphal[transport-udp,transport-serial,transport-can-pythoncan] ~= git+https://github.com/Willmac16/pycyphal@Willmac16/issue277
You can temporarily replace the Yakut dependency in PyCyphal integration tests in a similar fashion.
Once everything in this PR is good to go 🤞
~Can I squash my commits into one to keep the commit history of upstream clean.~
Edit: Looks like squashed merges are a built in GitHub feature so I'll refrain from doing it manually.
Addresses #277
I'm still a bit unsure about how I'm handling
nunavut_support.py
, so I'd appreciate feedback on that and anything else.