[Draft] Implement FileClient2, which raises on error

hannesweisbach commented 9 months ago

This PR aims to resolve issue #327. Currently it is in Draft status.

Open questions/issues:

List request does not seem to have an error code? Is this a bug in the Cyphal Spec?
~Use OSError or custom Exception type? (possibly derived from OSError)~
~docstrings need to be updated~
possibly more tests for exceptions (mocked?)
~server-side CI~
general feedback regarding coding style/guidelines (when not already mentioned by CI)
should FileClient2.get_info() also raise on error?

There is a test which tries to write /bin/sh under Linux, which I don't like. I don't think that's a good idea, because it just might succeed. After all, nox prompts for a sudo password ...

coveralls commented 9 months ago

coverage: 94.744% (+0.07%) from 94.679% when pulling e9c9bacc2ce15e6e8c6d9407b5abab40078923d7 on hannesweisbach:issue-327 into 765ab8d9bd22993f912cb7588763fbd7cdbe2b35 on OpenCyphal:master.

hannesweisbach commented 9 months ago

Just a quick review of the draft. Please mark the old FileClient deprecated.

Done.

OpenCyphal / pycyphal

[Draft] Implement FileClient2, which raises on error #328