search

OpenCyphal / pycyphal

Python implementation of the Cyphal protocol stack.
https://pycyphal.readthedocs.io/
MIT License
119 stars 106 forks source link

Add CAN-FD support to pyuavcan #38

Closed thirtytwobits closed 5 years ago

thirtytwobits commented 6 years ago

This is a preview as it is largely untested. Please comment but keep on a branch until more confidence is built.

Also note that I am unaware of any CAN-FD slcan devices on the market so this driver cannot be modified yet.

pavel-kirienko commented 6 years ago

Also note that I am unaware of any CAN-FD slcan devices on the market so this driver cannot be modified yet.

Yep, there aren't any, because SLCAN does not support CAN FD itself.

kjetilkjeka commented 6 years ago

Will these changes be tested in gui tool?

Is it much effort to make these changes available for gui_tool after the PR has landed?

pavel-kirienko commented 6 years ago

Is it much effort to make these changes available for gui_tool after the PR has landed?

The only thing requiring updates that comes to mind is the Bus Monitor widget - currently, it is built on the assumption that the maximum data length per frame is 8 bytes. Should be trivial to fix.

thirtytwobits commented 6 years ago

I'm deep in the libuavcan tests today. I'll get to this PR next week. I'll also take a look at the gui_tool next week.

thirtytwobits commented 6 years ago

Totally dropped the ball on this. Sorry. gui_tool is a problem for us because it is GPLv3. I don't want to touch this repo until I get guidance from our OSS guru. Any chance we can switch to wxwidgets or some other more liberally licensed GUI toolkit?

pavel-kirienko commented 6 years ago

Could you please ask your guru if LPGL is okay? We can use LGPL bindings while keeping our codebase MIT-licensed.

scottdarch commented 6 years ago

LPGL v3 is probably as bad if not worse. LGPL v2 is perhaps acceptable with review of the specific project and license.

pavel-kirienko commented 6 years ago

PySide2 is LGPLv3.

I suppose purchasing the commercial license of PyQt5 is not an option either?

I don't want to touch this repo until I get guidance from our OSS guru.

@thirtytwobits Pyuavcan is not affected by GPL, it is dependency-free.

scottdarch commented 6 years ago

Sorry, by "this repository" I meant gui_tool which I was discussing how to test this change's effect in the gui_tool.

pavel-kirienko commented 5 years ago

Closing as obsolete.