OpenCyphal / pycyphal

Python implementation of the Cyphal protocol stack.
https://pycyphal.readthedocs.io/
MIT License
119 stars 106 forks source link

v0 coexistence and data type extensibility #92

Closed pavel-kirienko closed 4 years ago

pavel-kirienko commented 4 years ago

This pull request implements the changes discussed in https://github.com/UAVCAN/specification/pull/64:

Also, I slightly relaxed the timing requirements in some test cases to reduce the probability of spurious failures due to poor real-time performance of the test suite.

Fixes #88 Fixes #89 Fixes #90

coveralls commented 4 years ago

Pull Request Test Coverage Report for Build 719


Changes Missing Coverage Covered Lines Changed/Added Lines %
pyuavcan/transport/can/_identifier.py 44 45 97.78%
pyuavcan/dsdl/_serialized_representation/_deserializer.py 80 82 97.56%
<!-- Total: 139 142 97.89% -->
Files with Coverage Reduction New Missed Lines %
.test_dsdl_generated/sirius_cyber_corp/PerformLinearLeastSquaresFit_1_0.py 1 90.98%
.test_dsdl_generated/uavcan/metatransport/can/ArbitrationID_0_1.py 1 88.76%
.test_dsdl_generated/uavcan/node/ExecuteCommand_1_0.py 1 91.39%
.test_dsdl_generated/uavcan/node/port/ID_1_0.py 1 88.76%
.test_dsdl_generated/uavcan/pnp/cluster/RequestVote_1_0.py 1 92.92%
.test_dsdl_generated/uavcan/pnp/NodeIDAllocationDataMTU8_0_1.py 1 86.32%
.test_dsdl_generated/uavcan/si/sample/duration/Scalar_1_0.py 1 83.33%
.test_dsdl_generated/uavcan/si/sample/energy/Scalar_1_0.py 1 83.33%
.test_dsdl_generated/uavcan/si/sample/volume/Scalar_1_0.py 1 83.33%
.test_dsdl_generated/uavcan/si/sample/volumetric_flow_rate/Scalar_1_0.py 1 83.33%
<!-- Total: 354 -->
Totals Coverage Status
Change from base Build 710: 0.5%
Covered Lines: 18368
Relevant Lines: 20556

💛 - Coveralls
thirtytwobits commented 4 years ago

Shouldn't you also bump the version with this change?