Implicit payload truncation implemented incorrectly - Githubissues

OpenCyphal / pycyphal

Python implementation of the Cyphal protocol stack.

https://pycyphal.readthedocs.io/

MIT License

119 stars 106 forks source link

Implicit payload truncation implemented incorrectly #93

Closed pavel-kirienko closed 4 years ago

pavel-kirienko commented 4 years ago

All error states related to the payload being too large shall be removed (PAYLOAD_SIZE_EXCEEDS_LIMIT, PAYLOAD_TOO_LARGE). The CRC computation should be done eagerly rather than lazily.

https://github.com/UAVCAN/pyuavcan/blob/867204ba6eba4b50a09f2ff6353ca0273e3ab51b/pyuavcan/transport/commons/high_overhead_transport/_transfer_reassembler.py#L164-L169

https://github.com/UAVCAN/pyuavcan/blob/867204ba6eba4b50a09f2ff6353ca0273e3ab51b/pyuavcan/transport/can/_session/_transfer_reassembler.py#L116-L122