maksimdrachov
commented
1 year ago Trying to test the example you gave here: https://github.com/maksimdrachov/test-serial-pr
Coming up with some inconsistency, the output of running this script:
serial_frame: SerialFrame(priority=NOMINAL, transfer_id=0, index=0, end_of_transfer=True, payload=303132333435363738, source_node_id=1234, destination_node_id=1, data_specifier=MessageDataSpecifier(subject_id=1234), user_data=0)
memoryview_output: b'\x00\x06\x01\x04\xd2\x04\x01\x03\xd2\x04\x01\x01\x01\x01\x01\x01\x01\x01\x01\x01\x02\x80\x01\x0c\xbd\x88012345678\x00'
(starting delimiter) memoryview_bytes[0]: b'\x00'
(COBS overhead byte) memoryview_bytes[1]: b'\x06'
(header) memoryview_bytes[2:2+24]:
b'\x01'
b'\x04'
b'\xd2'
b'\x04'
b'\x01'
b'\x03'
b'\xd2'
b'\x04'
b'\x01'
b'\x01'
b'\x01'
b'\x01'
b'\x01'
b'\x01'
b'\x01'
b'\x01'
b'\x01'
b'\x01'
b'\x02'
b'\x80'
b'\x01'
b'\x0c'
b'\xbd'
b'\x88'
(payload) memoryview_bytes[27:27+11]:
b'1'
b'2'
b'3'
b'4'
b'5'
b'6'
b'7'
b'8'
b'\x00'
COBS-encoded transfer-CRC b''
Traceback (most recent call last):
File "/Users/maksimdrachov/test-serial-pr/test-serial-pr.py", line 72, in <module>
"(ending delimiter) memoryview_bytes[44]: ", memoryview_bytes[44].to_bytes(1, "big")
~~~~~~~~~~~~~~~~^^^^
IndexError: index out of rangeIs it because pycyphal/serial hasn't been updated yet to reflect this new part? (No issue for this can be found tho)
Note: I think you forgot to mention which destination_node_id is used?
pavel-kirienko
Closes #99