search

OpenCyphal / yakut

Simple CLI tool for diagnostics and debugging of Cyphal networks
https://opencyphal.org
MIT License
49 stars 10 forks source link

controller: make midi [joystick] dependency optional #31

Closed coderkalyan closed 3 years ago

coderkalyan commented 3 years ago

Closes #23

Currently there is no fatal error if the library is not installed, as yakut.controller only brings a warning when a controller fails to load. I assume this is desired behavior in the case of multiple controller implementations so I didn't change it.

pavel-kirienko commented 3 years ago

The CI is red because the Nox test session should be updated to install the MIDI support after this block:

https://github.com/UAVCAN/yakut/blob/f4ca85cd3395f23296ce7fb706eef635799038e7/noxfile.py#L43-L45

It should go like session.install("-e", ".[joystick]")

pavel-kirienko commented 3 years ago

I just stumbled at this when I attempted to use Yakut in a CI workflow -- installation obviously fails due to missing multimedia libraries :D

Can we prioritize this, please?

pavel-kirienko commented 3 years ago

I just noticed that all my review feedback is addressed and the only thing that is holding us back is the broken CI. I am taking it over from here.