search

OpenCyphal / yakut

Simple CLI tool for diagnostics and debugging of Cyphal networks
https://opencyphal.org
MIT License
49 stars 10 forks source link

Change "Malformed data spec" to "Datatype doesn't exist" #42

Closed silverv closed 2 years ago

silverv commented 2 years ago

image This was confusing to me, I ended up trying 20 different ways to write '{command: 65533, parameter: hello}', eg 'command: 65533, parameter: hello' whereas the problem is the datatype name.

pavel-kirienko commented 2 years ago

The error message is correct though: the data specifier is malformed because it should be uavcan.node.ExecuteCommand.1.1 instead of uavcan.node.ExecuteCommand.

silverv commented 2 years ago

The message is not straightforward, you wouldn't know that as the creator

silverv commented 2 years ago

My unintentional usability test says revealed that my thought process is: "Okay, I need to change the way that I present the data to the uavcan.node.ExecuteCommand request constructor." While it should've been: "Oh, uavcan.node.ExecuteCommand doesn't exist, I forgot that I need to use the versioned notation"

pavel-kirienko commented 2 years ago

Okay, I see. Ideally, we should default to the latest available version if at least one version number is omitted.