The pet would be released, but the charm effect on the caster would persist (can't be cancelled), then drain mana and show resist chance on each pulse.
This was caused by IsWithinRadius returning true due to the zone not being updated yet (mob zone == player zone). Removing IsWithinRadius' call doesn't seem to have any negative impact and effects are properly cancelled when out of range.
Also removed the song.SpellHandler.Spell.InstrumentRequirement check since it's always 0. Minstrel's charm doesn't require an instrument to be kept active (confirmed through debugging), and even if we did we probably want to cancel the effect anyway.
https://bug.atlasfreeshard.com/issues/96 https://bug.atlasfreeshard.com/issues/167
The pet would be released, but the charm effect on the caster would persist (can't be cancelled), then drain mana and show resist chance on each pulse.
This was caused by IsWithinRadius returning true due to the zone not being updated yet (mob zone == player zone). Removing IsWithinRadius' call doesn't seem to have any negative impact and effects are properly cancelled when out of range.
Also removed the song.SpellHandler.Spell.InstrumentRequirement check since it's always 0. Minstrel's charm doesn't require an instrument to be kept active (confirmed through debugging), and even if we did we probably want to cancel the effect anyway.