search

OpenDDS / OpenDDS

OpenDDS is an open source C++ implementation of the Object Management Group (OMG) Data Distribution Service (DDS). OpenDDS also supports Java bindings through JNI.
http://www.opendds.org
Other
1.28k stars 463 forks source link

Move fuzz from travis-ci to github actions #1568

Closed jwillemsen closed 4 years ago

jwillemsen commented 4 years ago

See https://github.com/jwillemsen/OpenDDS/actions?query=workflow%3Afuzz

iguessthislldo commented 4 years ago

I am for this. The fact that linting errors can hide in timeouts on Travis has caused issues before.

jwillemsen commented 4 years ago

With github actions we get for free 20 concurrent jobs so this scales better (see https://help.github.com/en/actions/getting-started-with-github-actions/about-github-actions)

jwillemsen commented 4 years ago

For taox11 we are using github actions for compilation, works very good, see https://github.com/RemedyIT/taox11/actions

mitza-oci commented 4 years ago

What has to change in the GitHub repo configuration to get it to run the Action as part of the PR checks?

iguessthislldo commented 4 years ago

What has to change in the GitHub repo configuration to get it to run the Action as part of the PR checks?

There's an "Actions" page in the repo settings with radio switch to enable them.

mitza-oci commented 4 years ago

What has to change in the GitHub repo configuration to get it to run the Action as part of the PR checks?

There's an "Actions" page in the repo settings with radio switch to enable them.

It is (and has been) set to "Enable local and third party Actions for this repository"

jwillemsen commented 4 years ago

I didn't had to enable anything specifically for AXCIOMA/TAOX11/ACE

iguessthislldo commented 4 years ago

It is (and has been) set to "Enable local and third party Actions for this repository"

I didn't had to enable anything specifically for AXCIOMA/TAOX11/ACE

Yeah, I think it's enabled by default, but I wanted to give the option if Adam wanted to be sure.

jwillemsen commented 4 years ago

Any plans to merge this?

mitza-oci commented 4 years ago

Any plans to merge this?

Can we see the results of the GitHub actions here first? Or is it just not possible?

https://github.com/objectcomputing/OpenDDS/pull/1568/checks

jwillemsen commented 4 years ago

No idea how, I would expect it that github would trigger a new check

jwillemsen commented 4 years ago

It did run om my branch, can you see it there?

jwillemsen commented 4 years ago

https://github.com/jwillemsen/OpenDDS/actions

mitza-oci commented 4 years ago

It did run om my branch, can you see it there?

Sure, but that's not exactly what I'm asking about. If we are using this as a Check for each PR, then this very PR that we are working on should show it passing.

Maybe we should split this up so that this PR doesn't modify travis. Then once it's working we can come back and change travis.yml.

mitza-oci commented 4 years ago

Also, this may be a good opportunity to rename the script(s) since fuzz has an actual meaning in the wider software world (https://en.wikipedia.org/wiki/Fuzzing)

jwillemsen commented 4 years ago

See https://github.com/objectcomputing/OpenDDS/pull/1599

iguessthislldo commented 4 years ago

Also, this may be a good opportunity to rename the script(s) since fuzz has an actual meaning in the wider software world (https://en.wikipedia.org/wiki/Fuzzing)

If we're not doing that here, I would like to do it in #1366.