iguessthislldo
commented
2 weeks ago Some considerations:
- vcpkg does have Qt6
- CMake looks like it defers to the CMake support that ships with Qt, so we shouldn't have to worry about a minimum version of CMake that's required to use Qt6.
- There's two other projects in OpenDDS that use Qt, the "legacy" OpenDDS Monitor and ExcelRTD. We're planning on removing them in OpenDDS 4, but in the mean time they'd have to be excluded from the MPC build in the mean time because it doesn't really make sense to update them.
- Because of the previous point, it might be easier if shapes application retain Qt5 support so they can still all be built in the same build. Otherwise I don't think we have a real reason to keep Qt5 support.
- Right now we have two build systems, MPC (OpenDDS Qt MPC documentation) and CMake (shapes CMakeLists.txt). If we're updating MPC, it needs to be updated in MPC itself (See
qt5_core.mpband related files) and in the configure script. An alternative approach might be if we're keeping Qt5 support because of the old montior, we could bypass MPC changes altogether and Qt6 support could be a CMake-only change. - This should be a separate issue because it's its own repo, but it should be noted that the newer monitor that's unrelated to the older one also still uses Qt5.
So I think these are the possible approaches:
- Update MPC, the configure script, ishapes MPC file, ishapes CMakeLists.txt. Exclude the old montior and ExcelRTD from the MPC build if using Qt6.
- The same as above, but take out Qt5 support in the shapes demo. Then you have to choose if you want the shapes demo or the old monitor and ExcelRTD.
- Don't update MPC at all. Keep Qt5 support in the shapes demo. Only add optional Qt6 support to ishapes CMakeLists.txt.
BobMessiaen
jrw972
Qt6 has been out for a while now and I imagine Linux distros and vcpkg won't support Qt5 forever.
https://doc.qt.io/qt-6/portingguide.html