search

OpenDDS / OpenDDS

OpenDDS is an open source C++ implementation of the Object Management Group (OMG) Data Distribution Service (DDS). OpenDDS also supports Java bindings through JNI.
http://www.opendds.org
Other
1.28k stars 463 forks source link

Internal documentation lacks dependency management policy #4614

Closed jrw972 closed 1 week ago

jrw972 commented 2 weeks ago

Problem

The internal (developer) documentation lacks the policy used for managing the dependencies of OpenDDS.

Solution

Add it.

jrw972 commented 2 weeks ago

What about vcpkg?

iguessthislldo commented 2 weeks ago

This makes it sound like we're not using any branch of ACE/TAO in PR CI at all. With that, I'm concerned about having newly merged features in ACE/TAO and able to test that those are working correctly with an OpenDDS PR CI that's trying to use them.

jrw972 commented 1 week ago

This makes it sound like we're not using any branch of ACE/TAO in PR CI at all. With that, I'm concerned about having newly merged features in ACE/TAO and able to test that those are working correctly with an OpenDDS PR CI that's trying to use them.

If a PR requires an unreleased feature of ACE/TAO, then the PR author is free to change the ACE/TAO versions from release to the branches for the purpose of CI. However, I would push back against merging such a PR until the feature makes it into a released version of ACE/TAO at which point the ACE/TAO versions could be updated to a release version.

iguessthislldo commented 1 week ago

I would suggest something like an environment variable in the workflows to make it easier to switch the PRs to use git branches and maybe a lint check to make sure we don't accidentally merge that.