search

OpenDDS / rmw_opendds

ROS-2 support for OpenDDS
Apache License 2.0
7 stars 10 forks source link

merge eloquent branch into master #6

Closed adamsj-ros closed 4 years ago

adamsj-ros commented 4 years ago

Still very much a WIP but added azure-pipelines.yml to use CI to continue development.

iguessthislldo commented 4 years ago

I can't comment on it directly because it's not near something being changed, but these lines:

https://github.com/oci-labs/rmw_opendds/blob/920e07a437224751f357824ab1146b42073a62c8/rmw_opendds_cpp/CMakeLists.txt#L77-L78

should be replace by one or more target_link_libraries on the appropriate OpenDDS libraries that need to be used. There is an example of this in this CMakelists file.

adamsj-ros commented 4 years ago

I can't comment on it directly because it's not near something being changed, but these lines:

https://github.com/oci-labs/rmw_opendds/blob/920e07a437224751f357824ab1146b42073a62c8/rmw_opendds_cpp/CMakeLists.txt#L77-L78

should be replace by one or more target_link_libraries on the appropriate OpenDDS libraries that need to be used. There is an example of this in this CMakelists file.

With this PR, I'm trying to add consistency with the sibling repo, rosidl_typesupport_opendds. Since this project currently fails to build and this cmake change would best be verified with a clean build, I'll add a new issue and move this PR forward.