search

OpenDRR / earthquake-scenarios

Public repository for earthquake scenarios from the National catalogue / Dépôt public de scénarios de tremblements de terre du catalogue national
https://opendrr.github.io/earthquake-scenarios/
3 stars 8 forks source link

Rename three of the existing DSRA scenarios #77

Closed anthonyfok closed 1 year ago

anthonyfok commented 1 year ago

This pull request aims to rename the following three existing DSRA scenarios in the repository:

for better accuracy and consistency with RiskProfiler.ca. The source initialization files .ini, rupture models .xml and "FINISHED" CSV data *.csv are renamed where necessary, and the PNG map files and Markdown files regenerated.

Some minor tweaks were also made to the Bash and Python scripts as well as to the scenario descriptions.

Partially fixes the following issues:

Many thanks!

[Update] Missing French descriptions for the following recently added scenarios have been added, courtesy of DeepL Translator, in commit 03f0ab16abbc36931144cd91310b708af2030804:

AFAIK, all the scenario descriptions were translated with DeepL. We probably need real French speakers to review the translations some day. Also, I wonder if the title (e.g. M4.9 Georgia Strait Fault) should eventually be translated too?

drotheram commented 1 year ago

@tieganh Please review when able

DamonU2 commented 1 year ago

Going to need changes to dsra_scenario_map.md in /docs/_pages/en and /fr starting at line 449. I wasn't able to automate that part of the GitHub pages. Also, there's probably enough scenarios there to bring back the map that is currently commented out in the index.md (/en and /fr) files starting at line 73 (which also needs an edit to the link from my fork to the main repo).

wkhchow commented 1 year ago

Can we also remove the old scenario geopackages, and replace them with the new ones for 'completeness'? I have the new scenarios generated and can provide you the link. @anthonyfok

anthonyfok commented 1 year ago

Can we also remove the old scenario geopackages, and replace them with the new ones for 'completeness'? I have the new scenarios generated and can provide you the link. @anthonyfok

@wkhchow for sure! Sorry I missed your comment earlier, and failed to connect the dots when you first brought it up on Slack. Thank you for your reminder at Iteration Review last Thursday! The relevant GeoPackage files have been replaced in commit c35cf72. Cheers!