search

OpenDRR / model-factory

OpenQuake compilation and data manipulation scripts
https://opendrr.github.io/model-factory/
MIT License
2 stars 3 forks source link

DSRA - "gmpe_Model" indicator defaults to value "NBCC2020_TEST_PLACEHOLDER" for all views #57

Closed wkhchow closed 3 years ago

wkhchow commented 3 years ago

Just noticed all our DSRA views for "gmpe_Model" indicator defaults to "NBCC2020_TEST_PLACEHOLDER" and comes set a default value from DSRA_outputs2postgres_lfs.py

https://github.com/OpenDRR/model-factory/blob/master/scripts/DSRA_outputs2postgres_lfs.py

Need to check and verify actual source of gmpe values.

drotheram commented 3 years ago

This is a hardcoded placeholder, we should discuss where we need to parse this from.

jvanulde commented 3 years ago

This is a hardcoded placeholder, we should discuss where we need to parse this from.

Can you provide the permalink to the offending line please...

drotheram commented 3 years ago

https://github.com/OpenDRR/model-factory/blob/c2e08f87b913741363a8cb0645927bc2562d3f19/scripts/DSRA_outputs2postgres_lfs.py#L153

tieganh commented 3 years ago

So the correct place to get this value would be in the appropriate s_Hazard_NAME_ATTRIB.ini file, under the gsim_logic_tree_file attribute. For example:

https://github.com/OpenDRR/earthquake-scenarios/blob/master/initializations/s_Hazard_SIM9p0_CascadiaInterfaceBestFault.ini#L15

wkhchow commented 3 years ago

Tiegan mentioned the xml name can also be extracted from the scenario.md file under gsim_logic_tree_file whichever is the easiest way.

drotheram commented 3 years ago

Fixed by @DamonU2. Issue will be closed when 'update_hexbin_and_dsra_source' branch is merged to main branch

wkhchow commented 3 years ago

@DamonU2 has fixed the issue.