search

OpenDRR / pygeoapi

pygeoapi is a Python server implementation of the OGC API suite of standards. The project emerged as part of the next generation OGC API efforts in 2018 and provides the capability for organizations to deploy a RESTful OGC API endpoint using OpenAPI, GeoJSON, and HTML. pygeoapi is open source and released under an MIT license.
https://pygeoapi.io
MIT License
0 stars 1 forks source link

Dockerfile: Install pydantic with --no-binary #17

Open anthonyfok opened 2 years ago

anthonyfok commented 2 years ago

This is to reduce the size of the resulting Docker image, apparently from 969MB down to 861MB

Fixes #15

Questions: Is it a good idea to push this to master branch? Or to keep it just for a special pydantic-no-binary branch for AWS Lambda only? Many thanks!

anthonyfok commented 2 years ago

Turns out I probably changed the wrong Dockerfile: instead of the one in the top-level directory, I probably should have changed aws-lambda/container/Dockerfile instead. (Thanks to @arashmalekz's comment https://github.com/OpenDRR/pygeoapi/issues/15#issuecomment-981681839 telling me about the aws-lambda directory which I neglected.)

See also geopython/pygeoapi#709 for the origin of aws-lambda/container/Dockerfile.

Will revisit this in a future sprint (say Sprint 52?)

jvanulde commented 2 years ago

Note that since we don't deploy on Lambda any longer we don't need to worry about this.

anthonyfok commented 2 years ago

Note that since we don't deploy on Lambda any longer we don't need to worry about this.

Thanks so much Joost! I was wondering about that ('cause it was mentioned at our cloud tech meetings) but wasn't sure of the details.

I guess what is left to do in this PR is to (1) apply the change to the correct Dockerfile, and (2) submit a PR upstream, and then we can close this PR. Postponing this till we have more free time. :-)