[ISSUE 3] Inconsistencies with fractions and percentages

[anthonyfok]

From @tieganh:

Generally speaking, we need to be consistent with presenting things as fractions or as percentages, and not use the “%” on fractions. The example shown has a hover over value of “0.49%”, but the legend hover over for this shade of red is “44.44+ %“. If we are multiplying legend values by 100 and adding the “%”, then we should do the same for the hover over, detail box, and left hand table. Probably easier at this stage to omit the “%” and change legend values to fractions?

[anthonyfok]

@phil-evans replies:

i think this is also related to the changes to the rounding rules - this page was initially set up so that the returned data would follow the rounding rules that are created for the indicator in WP, but it seems to have lost that step after we added the new formatting logic. i’ll see if i can find where that’s going wrong

[anthonyfok]

@jvanulde replies:

I think easiest to multiply the hover over values by 100, and redo the legend to align with this maximum. @plesueur?

[anthonyfok]

@plesueur replies:

We should stay consistent with what we're presenting on the sidebar. For the 'probability of building damage' case, we use fractions and not a percent. So I agree with @tieganh to omit the % and change the legend values to fractions.

[anthonyfok]

@phil-evans asks:

just to confirm - for all of the ‘probability’ indicators, i should remove the % symbols from the popup and legend?

[anthonyfok]

@plesueur explains:

Follow the units displayed on the side panel. In other words:

• Anything related to the 'Probability of X building damage over 50 years', remove the % symbols from the map and legend (and the values in the legend should not be percentages either).

• The 'annual economic loss ratio', should remain as a percent, and the map pop-up should be a percent as well. Right now I think its not given as a percent, so please multiply this value by 100 so it matches the sidepanel (see screen shot below).

• The 'annual probability of fatality' is not represented as a % on the map or side panel (no changes needed for this one, just including for completeness)

[anthonyfok]

@phil-evans replies:

ok, i believe this is all right now:

[anthonyfok]

@phil-evans asks:

one thing i noticed - the annual economic loss ratio in the sidebar is pulling eAALm_Bldg, not eAALm_Asset.. not sure if that’s right or not

[wkhchow]

@phil-evans asks:

one thing i noticed - the annual economic loss ratio in the sidebar is pulling eAALm_Bldg, not eAALm_Asset.. not sure if that’s right or not

If that's the case I believe we want it to match asset for all, so annual economic loss ratio should b e pointing to eAALm_Asset and not eAALm_Bldg, which in the case for North Vancouver above should be 0.044% @plesueur

[plesueur]

yep, @wkhchow has got it right. Use eAALm_Asset.

Good catch @phil-evans