OpenData-NC / columbus-county-nc

OpenRural installation for Columbus County, NC
http://columbusco.openrural.org/
6 stars 1 forks source link

Filtering scraper runlist should not use POST #87

Closed kmtracey closed 12 years ago

kmtracey commented 12 years ago

The "Filter results" form (for example on http://columbusco-staging.openrural.org/data-dashboard/properties/) is currently using the POST method. This action doesn't make any changes to stored data, so it's not necessary to use POST. Using POST has the unfortunate side-effect, when the page is refreshed, of making the browser pop up a lay-person-incomprehensible message about re-submitting data and re-performing actions. When simply trying to refresh the list to see if a running scraper has finished, this popup is annoying even to someone who understands what it is saying.

This form should be changed to use the GET method, and the differing paths to take in the view can key off of 'submit' being present in request.GET rather than the request method being POST. I also think it would make sense to include 'running' in the list of default statuses: it's disconcerting when you press the "run" button and the page refreshes yet does not show that your now-running scraper is there. Possibly also include 'initialized' by default, though I've never seen one stay in that state long enough to catch it there.