OpenDataPolicingNC / Traffic-Stops

Open Data Policing NC aggregates, visualizes, and publishes public records related to all known traffic stops to have occurred in North Carolina since January 1, 2002.
https://opendatapolicingnc.com/
MIT License
25 stars 9 forks source link

ODPM-199: Fixing jsdom deps #207

Closed nmashton closed 7 years ago

nmashton commented 7 years ago

It turns out that we need to include a 9.x version of jsdom for tests to run. [See ODPM-199 in the Caktus JIRA.]

Once this is there, we can omit mocha-jsdom altogether, which seems like a good idea: it's not deprecated, but its page in NPM encourages you to not use it ("consider jsdom-global, a simpler alternative that also works outside of Mocha"), not a great sign for its future.

To verify this: pull the branch; rm -r node_modules; npm install; npm test.

trawick commented 7 years ago

:+1: