OpenDataScotland / jkan

A lightweight, backend-free open data portal, powered by Jekyll, based on the JKAN project
https://opendata.scot
MIT License
7 stars 13 forks source link

fix: improve table layout #9

Closed fozy81 closed 2 years ago

fozy81 commented 2 years ago

Description

This fixes issue https://github.com/OpenDataScotland/the_od_bods/issues/102

Motivation and Context

Other suggeted fixes:

How Has This Been Tested?

Tested locally. No units test (selenium etc written).

Screenshots (if appropriate):

image

Types of changes

Checklist:

JackGilmore commented 2 years ago

Looks good. Would maybe suggest taking off the text-orientation: sideways property as it doesn't look to have any effect and I don't think it's compatible with many browsers: https://caniuse.com/mdn-css_properties_text-orientation_sideways

fozy81 commented 2 years ago

I've switched to red gradient and flipped the text the other way and removed the text-orientation: sideways. Let me know if any more suggestions.

JackGilmore commented 2 years ago

Just looking at this and writing-mode: sideways-lr only seems to be supported by Firefox at the moment 😢 https://caniuse.com/mdn-css_properties_writing-mode_sideways_values.

You could maybe try wrapping the text in a span and then setting the following styles on the span?

writing-mode: vertical-lr;
transform: rotate(180deg);
fozy81 commented 2 years ago

Hi @JackGilmore - thanks for catching this, I'm testing on firefox. I've updated to use rotate. So much for web standards...why can't everyone just use firefox :smiley_cat:

JackGilmore commented 2 years ago

@fozy81 Looks great. Cheers for the contribution Tim!