Closed fozy81 closed 2 years ago
Looks good. Would maybe suggest taking off the text-orientation: sideways
property as it doesn't look to have any effect and I don't think it's compatible with many browsers: https://caniuse.com/mdn-css_properties_text-orientation_sideways
I've switched to red gradient and flipped the text the other way and removed the text-orientation: sideways. Let me know if any more suggestions.
Just looking at this and writing-mode: sideways-lr
only seems to be supported by Firefox at the moment 😢 https://caniuse.com/mdn-css_properties_writing-mode_sideways_values.
You could maybe try wrapping the text in a span and then setting the following styles on the span?
writing-mode: vertical-lr;
transform: rotate(180deg);
Hi @JackGilmore - thanks for catching this, I'm testing on firefox. I've updated to use rotate. So much for web standards...why can't everyone just use firefox :smiley_cat:
@fozy81 Looks great. Cheers for the contribution Tim!
Description
This fixes issue https://github.com/OpenDataScotland/the_od_bods/issues/102
Motivation and Context
Other suggeted fixes:
How Has This Been Tested?
Tested locally. No units test (selenium etc written).
Screenshots (if appropriate):
Types of changes
Checklist: