OpenDataServices / cove

CoVE is an web application to Convert, Validate and Explore data following certain open data standards - including 360Giving, Open Contracting Data Standard, IATI and the Beneficial Ownership Data Standard
http://cove.opendataservices.coop
Other
43 stars 11 forks source link

OCDS: Internal server error when null appears in parties array #1287

Closed duncandewhurst closed 4 years ago

duncandewhurst commented 4 years ago

Minimal example to reproduce issue - add null to the parties array:

{
  "version": "1.1",
  "uri": "https://github.com/open-contracting/sample-data/raw/1.1/fictional-example/ocds-213czf-000-00001.json",
  "publishedDate": "2011-01-10T09:30:00Z",
  "publisher": {
    "name": "Open Data Services Co-operative Limited",
    "scheme": "GB-COH",
    "uid": "9506232.0",
    "uri": "http://data.companieshouse.gov.uk/doc/company/09506232"
  },
  "license": "http://opendatacommons.org/licenses/pddl/1.0/",
  "publicationPolicy": "https://github.com/open-contracting/sample-data/",
  "releases": [
    {
      "ocid": "ocds-213czf-000-00001",
      "id": "ocds-213czf-000-00001-01-planning",
      "language": "en",
      "date": "2009-03-15T14:45:00Z",
      "initiationType": "tender",
      "tag": [
        "planning"
      ],
      "parties": [
        {
          "id": "GB-LAC-E09000003"
        },
        null
      ]
    }
  ]
}

Can this error be handled and reported to the user?

Related to CRM issue #6128

duncandewhurst commented 4 years ago

Investigate CoVE errors in Kingfisher Process Sentry

odscjames commented 4 years ago

Internal server error when null appears in parties array

rhiaro commented 4 years ago

This was fixed in lib-cove 0.18.0 and OCDS Cove with the new version has been deployed.