search

OpenDataServices / cove

CoVE is an web application to Convert, Validate and Explore data following certain open data standards - including 360Giving, Open Contracting Data Standard, IATI and the Beneficial Ownership Data Standard
http://cove.opendataservices.coop
Other
43 stars 11 forks source link

Failed files allows a converted download #165

Closed caprenter closed 8 years ago

caprenter commented 8 years ago

On 360Giving CoVE I use this url: http://www.wolfson.org.uk/media/2740/wolfson-foundation-grants-2014.xlsx

CoVE processes it. It fails to validate, but it offers me a converted JSON file. http://dev.cove.opendataservices.coop/media/606b8983-c75c-4c6f-8c3d-23d2cf26ddae//unflattened.json

This file is not 360Giving standard JSON.

I can't decide if this is ok or not!

We could maybe only provide the JSON if the file is valid - although a non-valid file is arguably still of some use. If we did want to offer a non-valid file, would it make sense to indicate that in some way.

All opinions gratefully received

Bjwebb commented 8 years ago

Validation is performed using the converted JSON, so I think we want to provide the invalid JSON to help people understand the validation messages, if nothing else.

Bjwebb commented 8 years ago

I strongly feel we should allow download, but flagging invalid JSON better may be useful. @kindly What are your thoughts on this?

robredpath commented 8 years ago

Closing - the new layout makes it clearer that the data is invalid. Please re-open if we want to revisit this!